Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add warning when running .NET Standard #2186

Merged
merged 3 commits into from Oct 1, 2019

Conversation

@rgomez90
Copy link
Contributor

rgomez90 commented Oct 1, 2019

Fixes #2164

What kind of change does this PR introduce?

  • Adds a warning message when running .NET Standard informing the user a host package needs to be installed.

What is the current behavior?

None

What is the new behavior?

None

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@rgomez90 rgomez90 requested a review from reactiveui/core-team as a code owner Oct 1, 2019
@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Oct 1, 2019

CLA assistant check
All CLA requirements met.

@glennawatson glennawatson changed the title Add warning when running .NET Standard Feature: Add warning when running .NET Standard Oct 1, 2019
src/ReactiveUI/RxApp.cs Outdated Show resolved Hide resolved
RLittlesII and others added 2 commits Oct 1, 2019
Co-Authored-By: Artyom <worldbeater-dev@yandex.ru>
@RLittlesII RLittlesII merged commit 76f6833 into reactiveui:master Oct 1, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.3.10+c8e705f9ab succeeded
Details
license/cla All CLA requirements met.
Details
@rgomez90 rgomez90 deleted the rgomez90:fix2164 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.