Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added SuspendLayout to RoutedViewHost WinForms control. #2200

Merged
merged 2 commits into from Oct 10, 2019

Conversation

@trucksmart
Copy link
Contributor

trucksmart commented Oct 9, 2019

What kind of change does this PR introduce?

Adds SuspendLayout to the RoutedViewHost WinForms control.

What is the current behavior?

SuspendLayout is missing.

What is the new behavior?

SuspendLayout has been added.

What might this PR break?
Nothing.

Please check if the PR fulfills these requirements

  • [ X ] Tests for the changes have been added (for bug fixes / features)
  • [ X ] Docs have been added / updated (for bug fixes / features)

Other information:
There currently isn't any way to check for a suspended layout in WinForms unless reflection is used.

@trucksmart trucksmart requested a review from reactiveui/winforms-team as a code owner Oct 9, 2019
@RLittlesII RLittlesII changed the title Added SuspendLayout to RoutedViewHost WinForms control. feature: Added SuspendLayout to RoutedViewHost WinForms control. Oct 9, 2019
Copy link
Contributor

RLittlesII left a comment

Do we need to add the region tags?

@RLittlesII

This comment has been minimized.

Copy link
Contributor

RLittlesII commented Oct 9, 2019

Seems the analyzers and ci agree with my thought.

@trucksmart

This comment has been minimized.

Copy link
Contributor Author

trucksmart commented Oct 9, 2019

Removed regions.

@glennawatson glennawatson merged commit e3ef2a8 into reactiveui:master Oct 10, 2019
2 checks passed
2 checks passed
ReactiveUI-CI Build #10.4.4+0ca0107beb succeeded
Details
license/cla All CLA requirements met.
@glennawatson

This comment has been minimized.

Copy link
Contributor

glennawatson commented Oct 10, 2019

Thanks @trucksmart we should have a version out in the next day or so with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.