Skip to content

Conversation

@trucksmart
Copy link
Contributor

What kind of change does this PR introduce?

Adds SuspendLayout to the RoutedViewHost WinForms control.

What is the current behavior?

SuspendLayout is missing.

What is the new behavior?

SuspendLayout has been added.

What might this PR break?
Nothing.

Please check if the PR fulfills these requirements

  • [ X ] Tests for the changes have been added (for bug fixes / features)
  • [ X ] Docs have been added / updated (for bug fixes / features)

Other information:
There currently isn't any way to check for a suspended layout in WinForms unless reflection is used.

@trucksmart trucksmart requested a review from a team October 9, 2019 19:50
@RLittlesII RLittlesII changed the title Added SuspendLayout to RoutedViewHost WinForms control. feature: Added SuspendLayout to RoutedViewHost WinForms control. Oct 9, 2019
Copy link
Member

@RLittlesII RLittlesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add the region tags?

@RLittlesII
Copy link
Member

Seems the analyzers and ci agree with my thought.

@trucksmart
Copy link
Contributor Author

Removed regions.

@glennawatson glennawatson merged commit e3ef2a8 into reactiveui:master Oct 10, 2019
@glennawatson
Copy link
Contributor

Thanks @trucksmart we should have a version out in the next day or so with this change.

@lock lock bot locked and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants