Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UWP sometimes crashes in threading #2208

Merged
merged 2 commits into from Oct 13, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Oct 13, 2019

Fixes an issue some users have when it attempts to access the a thread not associated with a UI.

@glennawatson glennawatson requested review from reactiveui/core-team as code owners Oct 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #2208 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   55.86%   55.86%           
=======================================
  Files         114      114           
  Lines        4495     4495           
  Branches      688      688           
=======================================
  Hits         2511     2511           
  Misses       1803     1803           
  Partials      181      181
Impacted Files Coverage Δ
...eUI/Platforms/windows-common/PlatformOperations.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49731b...123c529. Read the comment docs.

@glennawatson glennawatson merged commit e6f6498 into master Oct 13, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.4.9+5023edfc81 succeeded
Details
codecov/patch Coverage not affected when comparing cba968d...123c529
Details
codecov/project 55.86% remains the same compared to cba968d
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the glennawatson-fix-uwp-bug branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.