Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: the disposal analyzer errors #2209

Merged
merged 1 commit into from Oct 13, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Oct 13, 2019

The build is broken on several disposable points.

These don't need the Interlocked.Exchange since they have re-entry guards within them already.

@glennawatson glennawatson requested review from reactiveui/android-team as code owners Oct 13, 2019
@glennawatson glennawatson changed the title Fix: the disposal exceptions Fix: the disposal analyzer errors Oct 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 13, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@8fb45dc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2209   +/-   ##
=========================================
  Coverage          ?   55.86%           
=========================================
  Files             ?      114           
  Lines             ?     4495           
  Branches          ?      688           
=========================================
  Hits              ?     2511           
  Misses            ?     1803           
  Partials          ?      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb45dc...cba968d. Read the comment docs.

@glennawatson glennawatson merged commit f49731b into master Oct 13, 2019
4 checks passed
4 checks passed
ReactiveUI-CI Build #10.4.8+10b6001839 succeeded
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the glennawatson-fix-build branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.