Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception happening on startup of applications #2253

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Nov 20, 2019

What kind of change does this PR introduce?

bug fix.

What is the current behavior?

when loading on different platforms it will attempt to load DLLs for all the available NuGet packages we support. This will throw a FileNotFoundException.

What is the new behavior?

Does a file check to make sure the DLL is available before attempting to load the DLL.

What might this PR break?

Hopefully nobody.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Nov 20, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #2253 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2253      +/-   ##
==========================================
- Coverage   55.86%   55.81%   -0.05%     
==========================================
  Files         114      114              
  Lines        4495     4490       -5     
  Branches      688      688              
==========================================
- Hits         2511     2506       -5     
  Misses       1803     1803              
  Partials      181      181
Impacted Files Coverage Δ
src/ReactiveUI/Mixins/DependencyResolverMixins.cs 91.3% <100%> (+1.06%) ⬆️
src/ReactiveUI.Winforms/ReactiveUserControl.cs 50% <0%> (-11.54%) ⬇️
src/ReactiveUI.Winforms/ViewModelViewHost.cs 91% <0%> (-0.27%) ⬇️
src/ReactiveUI.Winforms/RoutedViewHost.cs 90.41% <0%> (-0.26%) ⬇️
.../ReactiveUI.Winforms/ViewModelViewHost.Designer.cs 100% <0%> (ø) ⬆️
...eactiveUI.Winforms/ReactiveUserControl.Designer.cs 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e932d...9d34e8b. Read the comment docs.

@glennawatson glennawatson merged commit 11e7f70 into master Nov 20, 2019
4 checks passed
4 checks passed
ReactiveUI-CI #10.5.33+ae3faca791 succeeded
Details
codecov/patch 100% of diff hit (target 55.86%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +44.13% compared to 02e932d
Details
license/cla All CLA requirements met.
@glennawatson glennawatson deleted the fix-exception-on-nuget-load branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.