-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feature: DefaultViewLocator now public for users to override ViewModelToViewFunc #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: DefaultViewLocator now public for users to override ViewModelToViewFunc #2275
Conversation
|
For some reason an unrelated test is broken in the CI build: https://dev.azure.com/dotnet/ReactiveUI/_build/results?buildId=25723&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=a8035825-ecc2-53a4-dc8f-13b782b0dc20&l=418 |
|
This isn't an unrelated test. These tests verify changes to the public API of the code. You changing from internal to public changes the API surface so the test failed. The api approval change should be uploaded to the artifacts of the build so you can see the difference between the old API surface and the new API surface. You should also be able to this to reproduce this locally running |
|
Install a diff program like |
|
You can copy .received.txt to .approved.txt -- that might get around your current issues. |
|
Thanks - now the winforms tests are crashing - I don't have a windows machine to test on I am afraid. |
|
We'll do the rest for you. Thanks for getting it this far. |
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
=======================================
Coverage 55.32% 55.32%
=======================================
Files 113 113
Lines 4334 4334
Branches 660 660
=======================================
Hits 2398 2398
Misses 1771 1771
Partials 165 165
Continue to review full report at Codecov.
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What kind of change does this PR introduce?
This is a feature update that allows users to override
DefaultViewLocator.ViewModelToViewFuncif they are using custom naming conventions.What is the current behavior?
Currently the users have to copy/paste the source of
DefaultViewLocatorand then change theirViewModelToViewFuncimplementation. This is dangerous because if the logic ofDefaultViewLocatorchanges, the copy-pasted code won't be able to carry the feature.What is the new behavior?
Allow users to get a reference to the locator thusly:
What might this PR break?
nothing
Please check if the PR fulfills these requirements
Other information:
Discussed with @anaisbetts on slack.