refactor: Remove the weak event managers #2276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabauman
approved these changes
Dec 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
==========================================
- Coverage 55.77% 55.32% -0.45%
==========================================
Files 114 113 -1
Lines 4486 4334 -152
Branches 688 660 -28
==========================================
- Hits 2502 2398 -104
+ Misses 1803 1771 -32
+ Partials 181 165 -16
Continue to review full report at Codecov.
|
worldbeater
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the weak event manager from ReactiveUI.
The weak event manager was originally introduced to attempt to solve memory leak issues with the WPF platform. We ended up getting
WhenActivatedfrom that instead.At the moment it's working for every platform that doesn't actually require it.
Weak events generally are a anti-pattern with observables since you have explicit cleanup mechanisms with Observables and you should be using those instead.