Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: Remove the weak event managers #2276
This removes the weak event manager from ReactiveUI.
The weak event manager was originally introduced to attempt to solve memory leak issues with the WPF platform. We ended up getting
At the moment it's working for every platform that doesn't actually require it.
Weak events generally are a anti-pattern with observables since you have explicit cleanup mechanisms with Observables and you should be using those instead.
@@ Coverage Diff @@ ## master #2276 +/- ## ========================================== - Coverage 55.77% 55.32% -0.45% ========================================== Files 114 113 -1 Lines 4486 4334 -152 Branches 688 660 -28 ========================================== - Hits 2502 2398 -104 + Misses 1803 1771 -32 + Partials 181 165 -16