fix: Blazor StateHasChanged not firing on ViewModel change #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2303 +/- ##
=======================================
Coverage 55.32% 55.32%
=======================================
Files 113 113
Lines 4334 4334
Branches 660 660
=======================================
Hits 2398 2398
Misses 1771 1771
Partials 165 165Continue to review full report at Codecov.
|
| { | ||
| var propertyChangedObservable = this.WhenAnyValue(x => x.ViewModel) | ||
| this.WhenAnyValue(x => x.ViewModel).Subscribe(_ => StateHasChanged()); | ||
| var viewModelsPropertyChanged = this.WhenAnyValue(x => x.ViewModel) |
Contributor
There was a problem hiding this comment.
Doesn't this still need a check for null? When I was testing this out, part of the issue is that the event chaining failed when the ViewModel was null.
Adding a .Where(x => x != null) or a default check should resolve that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298 where the view model property being changed doesn't trigger a state refresh.