Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add null check for blazor view model property changes #2305

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@glennawatson
Copy link
Contributor

glennawatson commented Jan 7, 2020

As pointed out by @michaelstonis in #2298 a null check is needed for the view model.

@glennawatson glennawatson requested a review from reactiveui/core-team as a code owner Jan 7, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #2305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   55.32%   55.32%           
=======================================
  Files         113      113           
  Lines        4334     4334           
  Branches      660      660           
=======================================
  Hits         2398     2398           
  Misses       1771     1771           
  Partials      165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7f45d...b450b32. Read the comment docs.

@glennawatson glennawatson merged commit 0f0b520 into master Jan 7, 2020
4 checks passed
4 checks passed
ReactiveUI-CI Build #11.1.7+3d9f480e21 succeeded
Details
codecov/patch Coverage not affected when comparing 8d7f45d...b450b32
Details
codecov/project 55.32% remains the same compared to 8d7f45d
Details
license/cla All CLA requirements met.
Details
@glennawatson glennawatson deleted the glennawatson-fix-null-check branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.