Skip to content

Conversation

@RLittlesII
Copy link
Member

What kind of change does this PR introduce?

Fixes a bug where NavigateBack was not firing NavigationStack changes.

What is the current behavior?

Resolves: #2286

What is the new behavior?

When NavigateBack is called the NavigationStack changes fire on the Router.Scheduler thread and the navigation works correctly.

What might this PR break?

Backwards navigation on Xamarin.Forms

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@RLittlesII RLittlesII requested a review from a team January 17, 2020 03:01
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #2315 into master will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2315     +/-   ##
=========================================
- Coverage   55.32%   54.73%   -0.6%     
=========================================
  Files         113      113             
  Lines        4334     4334             
  Branches      660      660             
=========================================
- Hits         2398     2372     -26     
- Misses       1771     1797     +26     
  Partials      165      165
Impacted Files Coverage Δ
...I.Winforms/WinformsCreatesObservableForProperty.cs 26.31% <0%> (-68.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0b520...19b5151. Read the comment docs.

@RLittlesII RLittlesII requested a review from a team January 17, 2020 03:51
@RLittlesII RLittlesII merged commit ab3feed into master Jan 17, 2020
@RLittlesII RLittlesII deleted the gh2286 branch January 17, 2020 04:10
@lock lock bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Router.NavigateBack seems to be broken in some cases

3 participants