Skip to content

Conversation

@glennawatson
Copy link
Contributor

What kind of change does this PR introduce?

fix

What is the current behavior?

There is a exception that happens when the ViewModel is changed, because the render hasn't happened yet.

What is the new behavior?

We fire the StateHasChanged in a InvokeAsync, which will dispatch it after the render.

What might this PR break?
Hopefully no-one.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson requested a review from a team January 28, 2020 06:33
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2334 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2334   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         113      113           
  Lines        4334     4334           
  Branches      660      660           
=======================================
  Hits         2372     2372           
  Misses       1797     1797           
  Partials      165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a0b5df...8909506. Read the comment docs.

@glennawatson glennawatson merged commit c0fc1d3 into master Jan 28, 2020
@glennawatson glennawatson deleted the glennawatson-fix-blazor-invoke branch January 28, 2020 06:50
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants