fix: Parameter tag on ReactiveComponentBase, moved WhenAny #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enAny statement to OnAfterRender.
RLittlesII
approved these changes
Jan 28, 2020
Member
RLittlesII
left a comment
RLittlesII
left a comment
There was a problem hiding this comment.
I am currently getting a dispatcher error on the line you just changed. Hopefully this resolves that issue as well.
RLittlesII
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix - moves WhenAny that was throwing errors in constructor to OnAfterRender.
Functionality - Adds
[Parameter]tag to ViewModel property in component base to allow allow users to compose ViewModel in Razor syntax.What is the current behavior?
kaboom basically.
What is the new behavior?
Hopefully not kaboom, although I've thought that before.
What might this PR break?
Nothing that ain't already broke.
Please check if the PR fulfills these requirements
Other information: