Skip to content

Conversation

@RLittlesII
Copy link
Member

What kind of change does this PR introduce?

Resolves an issue where the Blazor Component checking for a ViewModel property while rendering will cause an error

What is the current behavior?

It will setup a WhenAnyValue on the ViewModel in the constructor, before it's rendered and blow up.

What is the new behavior?

The WhenAny operator will only execute on the component after the component is rendered.

What might this PR break?

ReactiveUI.Blazor

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@RLittlesII RLittlesII requested a review from a team January 28, 2020 18:11
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #2336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2336   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         113      113           
  Lines        4334     4334           
  Branches      660      660           
=======================================
  Hits         2372     2372           
  Misses       1797     1797           
  Partials      165      165

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9f4585...ad13242. Read the comment docs.

@RLittlesII RLittlesII merged commit 46d4a60 into master Jan 28, 2020
@RLittlesII RLittlesII deleted the fix/blazor-component branch January 28, 2020 18:30
@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants