Mark deprecated fragment classes obsolete #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use readonly keyword where applicable. - Remove unused usings.
glennawatson
approved these changes
Mar 21, 2020
Contributor
|
After this one is merged can you please comment on #2367 with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fragment and PreferenceFragment were deprecated in API level 28:
https://developer.android.com/reference/android/preference/PreferenceFragment
https://developer.android.com/reference/android/app/Fragment
What is the current behavior?
Users can use these classes without warning.
What is the new behavior?
Users will be warned about these classes being obsolete, and encouraged to use the AndroidX or AndroidSupport equivalents.
What might this PR break?
Nothing.
Please check if the PR fulfills these requirements
Other information: