fix: Additional Subscriptions causing out of memory exception #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2400 +/- ##
=======================================
Coverage 54.69% 54.69%
=======================================
Files 114 114
Lines 4344 4344
Branches 663 663
=======================================
Hits 2376 2376
Misses 1801 1801
Partials 167 167 Continue to review full report at Codecov.
|
glennawatson
requested changes
Apr 30, 2020
| .Publish() | ||
| .RefCount(); | ||
| this.WhenAnyValue(x => x.ViewModel); | ||
|
|
Contributor
There was a problem hiding this comment.
Both need Where(x != null). Avoid the Skip below.
Add RefCount(2) and that should avoid the two observables being made.
glennawatson
approved these changes
May 1, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Resolves: #2377
What is the current behavior?
When you run the sample provided in the report after a few updates, Blazor will throw an
OutOfMemoryException.What is the new behavior?
The sample no longer throw the exception.
What might this PR break?
ReactiveComponentBasePlease check if the PR fulfills these requirements
Other information:
I tested my changes on a branch of the provided sample. I will note that even though I am now disposing of the subscription with a composite disposable, I stopped seeing the issue as soon as I moved it into the
firstRendercheck.I let the app run for over an hour and did not experience the issue. The most I did see logged on the memory footprint was a call to the GC that the nursery is full.
GC_MINOR: (Nursery full) time 5.00ms, stw 5.00ms promoted 287K major size: 1152K in use: 409K los size: 1024K in use: 16Khttps://github.com/RLittlesII/BlazorReactiveUI/tree/fix/memory-leak