Skip to content

Conversation

@luisllamasbinaburo
Copy link
Contributor

What kind of change does this PR introduce?
Improved TransitioningContentControl animations in WPF

  • Added more transitions (Fade, Move, Slide, Drop, Bounce)
  • Added DirectionProperty (Left, Right, Down, Up)
  • Added DurationProperty
  • Remove TransitionPart

What is the current behavior?

 <reactiveUi:RoutedViewHost x:Name="RoutedViewHost" Transition="SlideLeft"/>

What is the new behavior?

 <reactiveUi:RoutedViewHost x:Name="RoutedViewHost" Transition="Slide" Direction="Right" />

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@luisllamasbinaburo luisllamasbinaburo requested review from a team May 2, 2020 07:58
@dnfclas
Copy link

dnfclas commented May 2, 2020

CLA assistant check
All CLA requirements met.

@glennawatson
Copy link
Contributor

Hey there,

Is there any way of supporting the old animations so not to break existing users? I don't think many users would but be worth having backwards compatibility unless there is a great reason not to.

@glennawatson
Copy link
Contributor

No problem, I will merge it in and bump the version number then. Thanks for the contribute.

@luisllamasbinaburo
Copy link
Contributor Author

luisllamasbinaburo commented May 2, 2020

Hi, I think a lot about that, but found no "clean" solution.

Currently we have;

  • TransitionType: Fade, SlideLeft, FadeDown
  • TransitionPart: In, Out, InOut

But it is a little mess. For example, Fade can only be InOut, FadeDown can be In, Out, SlideLeft can be In, Out, but no InOut.

Now we have:

  • TransitionType: Fade, Slide, Move, Drop, Bounce
  • TransitionDirection: Left, Right, Up, Down

Of course, new Slide + Left is the same that old SlideLeft
But to keep full compatibility, we will need to keep SlideLeft in TransformationTypeEnum
So it will be

  • TransitionType: Fade, Slide, Move, Drop, Bounce + SlideLeft, FadeDown

And I think is most confusing.

What I have done is to keep default values as similar as I can.
For example, Default transistion is Fade, so if user have no change the property Transition in his RoutedViewHost, he will obtain the same behavior.
Or, if the user used SlideLeft transition, he only have to change "SlideLeft" with new "Slide", and will have the same animation again.

@glennawatson glennawatson merged commit 7bb038c into reactiveui:master May 2, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants