ObservableAsPropertyHelper.Value throws ArgumentNullException #2455 #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 24, 2020 08:37
Ensure OAPH CompositeDisposable is not null before subscribing Add unit test to cover case where OAPH has been disposed
|
|
Contributor
|
If possible for future PRs using the template helps users who are looking at the release notes to see what's changed Thanks for the fix much appreciated. |
glennawatson
approved these changes
Jul 24, 2020
Contributor
Author
You're welcome. Sorry about not using the template - it seemed to be almost the same as the Issue template, so I just referenced the issue. I just edited the PR using the template - I'm not sure if that helps at this point or not. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix and docs update
What is the current behavior?
ObservableAsPropertyHelper.Valuethrows anArgumentNullExceptionWhat is the new behavior?
ObservableAsPropertyHelper.Valuedoes not throw anArgumentNullExceptionWhat might this PR break?
Odd cases where users expect
ObservableAsPropertyHelper.Valueto throw anArgumentNullExceptionPlease check if the PR fulfills these requirements
Other information:
See issue #2455