Fix: BindTo and OneWayBind not working for null values #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennawatson
approved these changes
Aug 2, 2020
glennawatson
requested changes
Aug 2, 2020
Contributor
glennawatson
left a comment
glennawatson
left a comment
There was a problem hiding this comment.
Can you add a fourth lambda parameter test for one-way bind
Codecov Report
@@ Coverage Diff @@
## main #2477 +/- ##
==========================================
+ Coverage 51.86% 51.88% +0.02%
==========================================
Files 114 114
Lines 4525 4525
Branches 792 792
==========================================
+ Hits 2347 2348 +1
+ Misses 1950 1949 -1
Partials 228 228
Continue to review full report at Codecov.
|
glennawatson
approved these changes
Aug 2, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #2474, Fixes #2476
What is the current behavior?
BindTo and OneWayBind silently (but logged) stop working when attempting to assign null.
What is the new behavior?
Restores previous behavior, before regression: allows null to be assigned.
What might this PR break?
Nothing.
Please check if the PR fulfills these requirements
Other information: