Skip to content

Conversation

@cabauman
Copy link
Contributor

@cabauman cabauman commented Aug 4, 2020

What kind of change does this PR introduce?

Docs

What is the current behavior?

Resolves #2451

What is the new behavior?

Doesn't claim to assign the ViewModel property of IViewFor

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
Whether or not we want to change the default view locator implementation to populate the ViewModel property can be discussed and implemented in a separate PR.

@cabauman cabauman requested a review from a team August 4, 2020 03:20
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #2483 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2483   +/-   ##
=======================================
  Coverage   52.56%   52.56%           
=======================================
  Files         114      114           
  Lines        4522     4522           
  Branches      790      790           
=======================================
  Hits         2377     2377           
  Misses       1912     1912           
  Partials      233      233           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0bebd...211cf04. Read the comment docs.

@glennawatson glennawatson merged commit 5351c78 into main Aug 4, 2020
@glennawatson glennawatson deleted the fix/documentation branch August 4, 2020 05:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IViewLocator.ResolveView<T> return value documentation misleading for DefaultViewLocator.ResolveView<T> implementation

3 participants