Fix IPlatformOperations to be public like other registrable interfaces #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's super important that any interface we register in an `IWantsToRegisterStuff` is `public`, and ideally, the implementation too. This means that people can always extend ReactiveUI or support a new platform without having to fork the library
glennawatson
approved these changes
Feb 28, 2021
worldbeater
approved these changes
Feb 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #2691 +/- ##
=======================================
Coverage 63.57% 63.57%
=======================================
Files 132 132
Lines 4733 4733
=======================================
Hits 3009 3009
Misses 1724 1724 Continue to review full report at Codecov.
|
This was referenced Mar 12, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's super important that any interface we register in an
IWantsToRegisterStuffispublic, and ideally, the implementation too. This means that people can always extend ReactiveUI or support a new platform without having to fork the library