fix: Correct BindCommand Nullability Annotations #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
=======================================
Coverage 63.10% 63.10%
=======================================
Files 132 132
Lines 4740 4740
=======================================
Hits 2991 2991
Misses 1749 1749
Continue to review full report at Codecov.
|
glennawatson
approved these changes
May 2, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR updates nullability annotations for the
BindCommandextension method group.What is the current behavior?
Currently,
BindCommandrequires theTViewModelto not be null, although in fact the parameter doesn't have to not be null, we are using the parameter for generic type resolution only. The view model parameter is only used in one place insideBindCommand, we are passing the parameter to theReflection.ViewModelWhenAnyValueextension method, and the ViewModelWhenAnyValue extension method doesn't require theTViewModelto not be null.What is the new behavior?
The type annotations are updated.
What might this PR break?
Hopefully, nothing, let's wait for the CI checks to pass.