Update For Property Binding to make it easier to use Nullable values #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els and ViewModel Properties Updated Bind, OneWayBind and BindTo to allow nullable properties to be selected with less decorators. Sub properties will still require ! and ? operators as required. The Aim is to have less of an impact to those users upgrading older code.
Codecov Report
@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 62.63% 62.63%
=======================================
Files 133 133
Lines 4775 4775
=======================================
Hits 2991 2991
Misses 1784 1784
Continue to review full report at Codecov.
|
worldbeater
approved these changes
May 16, 2021
worldbeater
reviewed
May 16, 2021
| where TViewModel : class | ||
| where TView : class, ReactiveUI.IViewFor { } | ||
| [return: System.Runtime.CompilerServices.TupleElementNames(new string[] { | ||
| [return: System.Runtime.CompilerServices.TupleElementNames(new string?[]?[] { |
Contributor
There was a problem hiding this comment.
The string?[]?[] signature looks like a curious bug in the API generator btw. Not particularly related to the changes in this PR, just sharing a minor observation
ChrisPulman
deleted the
UpdateForPropertyBinding_Bind_OneWayBind_BindTo_ForNullableProperties
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Bind, OneWayBind and BindTo to allow nullable properties to be selected with less decorators.
Sub properties will still require ! and ? operators as required.
The Aim is to have less of an impact to those users upgrading older code.
What kind of change does this PR introduce?
update
What is the current behaviour?
Bind, OneWayBind and BindTo all require additional Nullable decorators to remove 'result may be null' compiler warnings for Nullable ViewModels and Properties
What is the new behaviour?
The Bind, OneWay and BindTo property binding extension methods now do not require additional decorators for the ViewModel and the first property
What might this PR break?
None expected, but a code review should take place to remove any additional ! and ? decorators that may have been used previously
Please check if the PR fulfils these requirements
Other information: