feature WhenAnyObservable, WhenAny and WhenAnyValue to make Nullable #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhenAnyObservable WhenAnyValue WhenAny updated to take a Nullable first parameter Updated editorconfig to make var the prominent of Explicit types as per the website suggestion Fixed a few non compliances to the coding standard
ChrisPulman
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2760 +/- ##
==========================================
- Coverage 62.63% 62.49% -0.15%
==========================================
Files 133 133
Lines 4775 4709 -66
==========================================
- Hits 2991 2943 -48
+ Misses 1784 1766 -18
Continue to review full report at Codecov.
|
Reflection: unfortunately CS0165 rule stops me from using :
if (member is not FieldInfo field)
{
return (obj, _) => field.GetValue(obj) ?? throw new InvalidOperationException();
}
PanelSetMethodBindingConverters:
Reverted code and put IDE0046 rule in source to stop future updates to suggested
glennawatson
approved these changes
May 17, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WhenAnyObservable
WhenAnyValue
WhenAny
updated to take a Nullable first parameter
Updated editorconfig to make var the prominent of Explicit types as per the website suggestion
Fixed a few non compliances to the coding standard
What kind of change does this PR introduce?
update
What is the current behaviour?
WhenAnyObservable, WhenAnyValue and WhenAny currently require decorators to allow nullable objects to be used
What is the new behaviour?
WhenAnyObservable, WhenAnyValue and WhenAny should nowrequire less decorators to allow nullable objects to be used
What might this PR break?
none expected, a code review should be done on existing code to remove any redundant ! and ? decorators
Please check if the PR fulfils these requirements
Other information: