feature RoutingState NavigateBack Result Type To IRoutableViewModel closes #2743 #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Routing state to provide the nullable ViewModel upon navigating or Null if the stack is empty closes #2743
Codecov Report
@@ Coverage Diff @@
## main #2761 +/- ##
=======================================
Coverage 62.49% 62.49%
=======================================
Files 133 133
Lines 4709 4709
=======================================
Hits 2943 2943
Misses 1766 1766
Continue to review full report at Codecov.
|
glennawatson
approved these changes
May 17, 2021
glennawatson
deleted the
FeatureRoutingStateNavigateBackResultTypeToIRoutableViewModel
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Routing state to provide the nullable ViewModel upon navigating or Null if the stack is empty
closes #2743
What kind of change does this PR introduce?
feature
What is the current behaviour?
NavigateBack returns a Unit
What is the new behaviour?
NavigateBack returns a nullable IRoutableViewModel
What might this PR break?
may produce compile errors if there is currently a usage of the NavigateBack provided Unit
Please check if the PR fulfils these requirements
Other information: