fix: change signature of CommandBinderImplementation #2766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make BindToObject, ResolveView, and OAPH Nullable Fix some other code standard issues in ReactiveUI project
Updated CanActiveate to fix a bug, added tests to cover the three possibilities Updated CommandBinder to fix a bug when using events, added tests, but outstanding bug with Func<T> to IObservable<T> and Command parameter types returning Reactive.Unit instead of T Commit to get update of CodeCov report
Coverage should be at maximum for this class, the final null check I believe can never be null as all is checked prior to the reflection being called
…generate codecov report Updated IDE0046 to suggestion as requested
As I was unable to resolve the Func<T> to Observable<T> I changed the signature to Expresssion<Func<TViewmodel, TParm>>, removed the option for generating a Command for the Parameter as can convert Expresssion<Func<TViewmodel, TParm>> to IObservable<TParam>
Codecov Report
@@ Coverage Diff @@
## main #2766 +/- ##
==========================================
+ Coverage 62.55% 62.84% +0.29%
==========================================
Files 133 134 +1
Lines 4687 4686 -1
==========================================
+ Hits 2932 2945 +13
+ Misses 1755 1741 -14
Continue to review full report at Codecov.
|
glennawatson
changed the title
glennawatson
approved these changes
May 21, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behaviour?
CommandBinderImplementation BindCommand has a overload that uses Func param this fails to be bound to a Command and the Observable only fires once
What is the new behaviour?
CommandBinderImplementation BindCommand has a overload that uses Expression<Func<TViewModel, T> param this is convertable to a IObservable and fires when required
What might this PR break?
As this method is not a Extension method the usage may be low the signature has changed but uses a variable that is already required in addition to a property
Please check if the PR fulfils these requirements
Other information: