Fix: Allow IReactiveObject to access subscription extensions #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2021 19:57
- this change enables consumers to implement IReactiveObject and get PropertyChanged and PropertyChanging notifications (which regressed in version 11.4.1) - to get the notifications, one must call this.SubscribePropertyChangedEvents() or this.SubscribePropertyChangingEvents() on the IReactiveObject instance - related: reactiveui#2594
- there were unit tests failing because they compared string representations of double in the CultureInfo.InvariantCulture format. This was changed to CultureInfo.CurrentCulture to work with the culture of the Device running the tests
bruzkovsky
commented
Jun 1, 2021
| var disp1 = fixture.Bind(vm, view, x => x.JustADecimal, x => x.SomeTextBox.Text, (IObservable<Unit>?)null, null); | ||
|
|
||
| Assert.Equal(vm.JustADecimal.ToString(CultureInfo.InvariantCulture), view.SomeTextBox.Text); | ||
| Assert.Equal(vm.JustADecimal.ToString(CultureInfo.CurrentCulture), view.SomeTextBox.Text); |
Contributor
Author
There was a problem hiding this comment.
These tests were failing on my machine, because here in Austria we have comma "," as decimal separator. I suppose this now runs on every machine, but I'll revert it if breaks something
bruzkovsky
commented
Jun 1, 2021
| } | ||
|
|
||
| Assert.Equal(approvedPublicApi, receivedPublicApi); | ||
| Assert.Equal(approvedPublicApi.Trim(), receivedPublicApi); |
Contributor
Author
There was a problem hiding this comment.
I don't know why my VS keeps adding a blank line at the end of the approval files when saving, but with this the tests are green.
glennawatson
changed the title
Contributor
|
Thanks for the PR, I will do a release in the next day or so. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Custom implementation of
IReactiveObjectdoes not fire PropertyChanging and PropertyChanged events.See #2594
What is the new behavior?
IReactiveObjectExtensions.SubscribePropertyChangedEventsandIReactiveObjectExtensions.SubscribePropertyChangingEvents arenow publicWhat might this PR break?
This PR breaks the public API by adding two new public extension methods
IReactiveObjectExtensions.SubscribePropertyChangedEventsandIReactiveObjectExtensions.SubscribePropertyChangingEvents arePlease check if the PR fulfills these requirements
Other information: