feature for Xamarin added ReactiveShell, ReactiveShellContent, ReactiveFlyOut #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactiveShell can be used when you wish to use a viewmodel on your base NOTE: Only supports WhenActivated NOT WhenDeactivated due to the Base nature of the Shell component ShellViewModel is a ViewModel based version of ShellContent
Codecov Report
@@ Coverage Diff @@
## main #2814 +/- ##
==========================================
+ Coverage 65.04% 65.77% +0.73%
==========================================
Files 134 137 +3
Lines 4712 4810 +98
==========================================
+ Hits 3065 3164 +99
+ Misses 1647 1646 -1
Continue to review full report at Codecov.
|
RLittlesII
reviewed
Jun 29, 2021
RLittlesII
reviewed
Jun 29, 2021
Rename ShellViewModel to ReactiveShellContent to keep in with other extended elements
ChrisPulman
changed the title
RLittlesII
reviewed
Jul 6, 2021
RLittlesII
approved these changes
Jul 6, 2021
RLittlesII
deleted the
feature_Xamarin_ReactiveShell_ShellViewModel_ReactiveFlyOut
branch
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactiveShell can be used when you wish to use a viewmodel on your base
NOTE: Only supports WhenActivated NOT WhenDeactivated due to the Base nature of the Shell component
ReactiveShellContent is a ViewModel based version of ShellContent
What kind of change does this PR introduce?
feature
What is the current behaviour?
Shell and FlyOut have no base in ReactiveUI.Xamarin
What is the new behaviour?
ReactiveShell, ReactiveShellContent, ReactiveFlyOut added to give a base for Shell and Flyout and allow further development
What might this PR break?
none
Please check if the PR fulfils these requirements
Other information:
ReactiveShell will ONLY support WhenActivated NOT WhenDeactivated due to the Base SPA nature of the Shell component