Skip to content

Conversation

@ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Jul 9, 2021

Added Bind to List test with ReadOnlyObservableCollection
put solution items into two folders, Src and Tests

What kind of change does this PR introduce?

test

What is the current behaviour?

What is the new behaviour?

added test

What might this PR break?

none expected

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Added BindList for use with SourceList
@glennawatson
Copy link
Contributor

An issue with this one is SourceList is not meant to be exposed to the UI layer at all. Its fundamnetally against the way DD works.

@glennawatson
Copy link
Contributor

Why use a SourceList directly is the other concern I have, it's meant to be for data which you observe, transform, filter etc.

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2823 (12369ab) into main (f97fb4b) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2823      +/-   ##
==========================================
+ Coverage   68.26%   68.28%   +0.02%     
==========================================
  Files         137      137              
  Lines        4787     4787              
==========================================
+ Hits         3268     3269       +1     
+ Misses       1519     1518       -1     
Impacted Files Coverage Δ
...orms/windows-common/AutoDataTemplateBindingHook.cs 94.44% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97fb4b...12369ab. Read the comment docs.

@ChrisPulman
Copy link
Member Author

Ok, I will rethink this to try a different approach

@ChrisPulman ChrisPulman marked this pull request as draft July 9, 2021 03:26
@ChrisPulman ChrisPulman marked this pull request as ready for review July 9, 2021 04:12
@ChrisPulman ChrisPulman changed the title feature BindList tests Binding to List test Jul 9, 2021
@ChrisPulman
Copy link
Member Author

0.02% hmmm every little helps I guess

@glennawatson glennawatson merged commit de9557f into main Jul 9, 2021
@glennawatson glennawatson deleted the feature_bindList branch July 9, 2021 23:22
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants