Skip to content

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

feature add more IBindingTypeConverter implementations #1070

What is the current behaviour?

only a few IBindingTypeConverter implementations exist

What is the new behaviour?

common type converters added

What might this PR break?

none expected as if a user registers their own it should be resolved instead of the base functions
They may need to raise the affinity value above our base level of 10.

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #2869 (a2bb864) into main (ea20555) will increase coverage by 0.42%.
The diff coverage is 84.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2869      +/-   ##
==========================================
+ Coverage   71.79%   72.22%   +0.42%     
==========================================
  Files         139      140       +1     
  Lines        4890     4926      +36     
==========================================
+ Hits         3511     3558      +47     
+ Misses       1379     1368      -11     
Impacted Files Coverage Δ
.../Bindings/Converter/SingleToStringTypeConverter.cs 61.90% <61.90%> (ø)
src/ReactiveUI.Winforms/Registrations.cs 82.35% <100.00%> (-9.96%) ⬇️
src/ReactiveUI.Wpf/Registrations.cs 82.35% <100.00%> (-9.96%) ⬇️
src/ReactiveUI.XamForms/Registrations.cs 87.50% <100.00%> (+12.50%) ⬆️
...Bindings/Converter/DecimalToStringTypeConverter.cs 100.00% <100.00%> (+52.38%) ⬆️
.../Bindings/Converter/DoubleToStringTypeConverter.cs 90.47% <100.00%> (+90.47%) ⬆️
src/ReactiveUI/Registration/Registrations.cs 93.33% <100.00%> (+1.66%) ⬆️
...ReactiveUI/Platforms/net5/PlatformRegistrations.cs 57.14% <0.00%> (-28.58%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea20555...a2bb864. Read the comment docs.

@ChrisPulman ChrisPulman marked this pull request as ready for review August 12, 2021 12:08
@ChrisPulman ChrisPulman merged commit 58a4381 into main Aug 12, 2021
@ChrisPulman ChrisPulman deleted the feature_AddStandardBindingConverters branch August 12, 2021 12:08
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants