Skip to content

build(deps): bump Microsoft.NET.Test.Sdk from 16.10.0 to 16.11.0 in /integrationtests #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 16, 2021
Merged

build(deps): bump Microsoft.NET.Test.Sdk from 16.10.0 to 16.11.0 in /integrationtests #2874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5de4d9d
build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests
dependabot[bot] Aug 16, 2021
7c7cf43
Merge branch 'main' into dependabot/nuget/integrationtests/Microsoft.…
ChrisPulman Aug 16, 2021
569a72d
build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests
dependabot[bot] Aug 16, 2021
0aa2ebc
Update ReactiveCommandTest.cs
ChrisPulman Aug 16, 2021
0cab1fd
Merge branch 'dependabot/nuget/integrationtests/Microsoft.NET.Test.Sd…
ChrisPulman Aug 16, 2021
23dd934
build(deps): bump Microsoft.NET.Test.Sdk in /integrationtests
dependabot[bot] Aug 16, 2021
1dbf368
Merge branch 'dependabot/nuget/integrationtests/Microsoft.NET.Test.Sd…
ChrisPulman Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrationtests/IntegrationTests.Shared.Tests/IntegrationTests.Shared.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.console" Version="2.4.1">
<PrivateAssets>all</PrivateAssets>
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</PropertyGroup>

<ItemGroup Condition="$(IsTestProject)">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.10.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0" />
<PackageReference Include="xunit" Version="2.4.1" />
<PackageReference Include="xunit.runner.console" Version="2.4.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
Expand Down
16 changes: 9 additions & 7 deletions src/ReactiveUI.Tests/Commands/ReactiveCommandTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,11 +1158,13 @@ public async Task ReactiveCommandCreateFromTaskHandlesTaskExceptionAsync()
var subj = new Subject<Unit>();
var isExecuting = false;
Exception? fail = null;
var fixture = ReactiveCommand.CreateFromTask(async _ =>
{
await subj.Take(1);
throw new Exception("break execution");
});
var fixture = ReactiveCommand.CreateFromTask(
async _ =>
{
await subj.Take(1);
throw new Exception("break execution");
});

fixture.IsExecuting.Subscribe(x => isExecuting = x);
fixture.ThrownExceptions.Subscribe(ex => fail = ex);

Expand All @@ -1175,8 +1177,8 @@ public async Task ReactiveCommandCreateFromTaskHandlesTaskExceptionAsync()

subj.OnNext(Unit.Default);

// Wait 1 ms to allow execution to complete
await Task.Delay(1).ConfigureAwait(false);
// Wait 10 ms to allow execution to complete
await Task.Delay(10).ConfigureAwait(false);

Assert.False(isExecuting);
Assert.Equal("break execution", fail?.Message);
Expand Down