Skip to content

Conversation

@ChrisPulman
Copy link
Member

Changed ObserveOn to only affect the internal subscription

What kind of change does this PR introduce?

fix #2866

What is the current behaviour?

CanExecute stops Execute functioning when ObserveOn is assigned to global function

What is the new behaviour?

CanExecute only has ObserveOn assigned to internal subscription

What might this PR break?

none expected all existing tests are passing

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Changed ObserveOn to only affect the internal subscription
@ChrisPulman ChrisPulman enabled auto-merge (squash) August 16, 2021 15:13
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #2880 (d34db1c) into main (42e2e90) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
- Coverage   71.97%   71.95%   -0.02%     
==========================================
  Files         144      144              
  Lines        5006     5007       +1     
==========================================
  Hits         3603     3603              
- Misses       1403     1404       +1     
Impacted Files Coverage Δ
src/ReactiveUI/ReactiveCommand/ReactiveCommand.cs 82.94% <100.00%> (+0.07%) ⬆️
...ctiveUI/Platforms/windows-common/RoutedViewHost.cs 86.44% <0.00%> (-1.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e2e90...d34db1c. Read the comment docs.

@ChrisPulman ChrisPulman added the release Gets released. label Aug 17, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release Gets released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] InvokeCommand doesn't invoke command

3 participants