Skip to content

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

feature

What is the current behaviour?

support up to net 5

What is the new behaviour?

basic support for net 6

What might this PR break?

as Net 6 is still preview, features subject to change

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #2887 (f37ae1f) into main (c629a31) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
+ Coverage   71.96%   72.19%   +0.22%     
==========================================
  Files         144      140       -4     
  Lines        5008     4905     -103     
==========================================
- Hits         3604     3541      -63     
+ Misses       1404     1364      -40     
Impacted Files Coverage Δ
...activeUI.Uwp/Common/AutoDataTemplateBindingHook.cs 94.44% <ø> (ø)
...eUI.Uwp/Common/BooleanToVisibilityTypeConverter.cs 70.58% <ø> (ø)
src/ReactiveUI.Uwp/Common/PlatformOperations.cs 0.00% <ø> (ø)
src/ReactiveUI.Uwp/Common/ReactivePage.cs 0.00% <ø> (ø)
src/ReactiveUI.Uwp/Common/ReactiveUserControl.cs 90.90% <ø> (ø)
src/ReactiveUI.Uwp/Common/RoutedViewHost.cs 86.44% <ø> (ø)
src/ReactiveUI.Uwp/Common/ViewModelViewHost.cs 83.33% <ø> (ø)
...iveUI/Platforms/net/ComponentModelTypeConverter.cs 52.77% <ø> (ø)
.../ReactiveUI/Platforms/net/PlatformRegistrations.cs 57.14% <ø> (ø)
src/ReactiveUI/Mixins/DependencyResolverMixins.cs 94.44% <100.00%> (+0.10%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c629a31...f37ae1f. Read the comment docs.

@glennawatson glennawatson marked this pull request as draft August 20, 2021 00:46
@ChrisPulman ChrisPulman marked this pull request as ready for review August 21, 2021 14:28
@ChrisPulman ChrisPulman enabled auto-merge (squash) August 21, 2021 14:28
@ChrisPulman ChrisPulman merged commit 37fb9ae into main Aug 21, 2021
@ChrisPulman ChrisPulman deleted the featureAddnet6Support branch August 21, 2021 14:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] When running NET6 WPF, it errors: Could not load type 'System.Reactive.Concurrency.DispatcherScheduler'

3 participants