Skip to content

Conversation

@ChrisPulman
Copy link
Member

use ReactiveMarbles.ObservableEvents.SourceGenerator instead of using ReactiveUI.Events.*

What kind of change does this PR introduce?

feature removal

What is the current behaviour?

using ReactiveUI.Events.*

What is the new behaviour?

use ReactiveMarbles.ObservableEvents.SourceGenerator instead of using ReactiveUI.Events.*

What might this PR break?

users will need to migrate to ReactiveMarbles.ObservableEvents.SourceGenerator

Please check if the PR fulfils these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

use ReactiveMarbles.ObservableEvents.SourceGenerator instead of using ReactiveUI.Events.*
@ChrisPulman ChrisPulman enabled auto-merge (squash) August 21, 2021 11:19
@glennawatson glennawatson changed the title depreciate ReactiveUI.Events.* deprecate ReactiveUI.Events.* Aug 21, 2021
@glennawatson glennawatson disabled auto-merge August 21, 2021 11:33
@glennawatson glennawatson enabled auto-merge (squash) August 21, 2021 11:34
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #2892 (f1975bc) into main (eb3e4b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2892   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files         144      144           
  Lines        5008     5008           
=======================================
  Hits         3604     3604           
  Misses       1404     1404           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3e4b4...f1975bc. Read the comment docs.

@glennawatson glennawatson merged commit c629a31 into main Aug 21, 2021
@glennawatson glennawatson deleted the housekeepingRemoveEvents branch August 21, 2021 12:33
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants