Skip to content

Conversation

@harvinders
Copy link
Contributor

What kind of change does this PR introduce?

It adds support for WinUI 3 desktop. Will add more information as I proceed further.

What is the current behavior?

What is the new behavior?

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@dnfadmin
Copy link

dnfadmin commented Aug 22, 2021

CLA assistant check
All CLA requirements met.

@glennawatson glennawatson changed the title WIP: Support for WinUI3 desktop Feature: Support for WinUI3 desktop Aug 22, 2021
@glennawatson
Copy link
Contributor

We will merge your PR then add support for net6 version as well.

Thanks for your help.

@glennawatson glennawatson merged commit 66a4d38 into reactiveui:main Aug 22, 2021
@kmgallahan
Copy link

@harvinders When I install the ReactiveUI.WinUI package I receive this error:

Screenshot 2021-10-03 135528

This is with a blank WinUI 3 desktop app created using the Windows App SDK 1.0.0-preview1 template (with no page declarations in the project files).

@harvinders
Copy link
Contributor Author

harvinders commented Oct 3, 2021

It is maybe because Microsoft has decided to rename the nuget package from Microsoft.ProjectReunion to Microsoft.WindowsAppSDK in preview 1.

ReactiveUI.WinUI package would need to be complied with final released version 1.0 to fix it.

@glennawatson
Copy link
Contributor

This is why we normally never support anything that hasn't had a full release.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants