fix BindCommand Tests #2906
Merged
fix BindCommand Tests #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BindCommand with parameter incorrectly coded OLD Assert.Equal(0, received); NEW Assert.Equal(13, received);
Codecov Report
@@ Coverage Diff @@
## main #2906 +/- ##
==========================================
- Coverage 72.21% 72.19% -0.03%
==========================================
Files 140 140
Lines 4906 4906
==========================================
- Hits 3543 3542 -1
- Misses 1363 1364 +1
Continue to review full report at Codecov.
|
glennawatson
approved these changes
Aug 25, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
What is the current behaviour?
BindCommand with parameter incorrectly coded in tests
OLD Assert.Equal(0, received);
What is the new behaviour?
NEW condition Assert.Equal(13, received);
What might this PR break?
none but documentation for using BindCommand with parameter using Expression<Func> may need a better explanation
Please check if the PR fulfils these requirements
Other information:
This update is related to #2904 but proves that the function is working as expected.
User code may need to be updated to ensure correct operation