Skip to content

Conversation

@sanskar-mk2
Copy link

Let me know if any changes are required. Thank you.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. But I can see translation done from line 236.

Can you do the translation of rest of the file.

We can start the review once whole file is translated

@github-actions
Copy link

github-actions bot commented Apr 5, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/describing-the-ui 58.66 KB (🟡 +292 B) 153.85 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@arshadkazmi42
Copy link
Member

@sanskar-mk2 Can you translate the full file and let me know once done.

I will start review once the translation of complete file is done.

@arshadkazmi42
Copy link
Member

@sanskar-mk2 I was checking the page which was assigned to you, in the PR you have translated the wrong page.
This is the page assigned to you https://github.com/reactjs/hi.reactjs.org/blob/main/beta/src/pages/learn/passing-props-to-a-component.md

Can you work on translating this and update the PR.

@sanskar-mk2 sanskar-mk2 closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1st Review First phase of review beta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants