-
Notifications
You must be signed in to change notification settings - Fork 16
Sync with reactjs.org @ ddbd064d #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
… spanish (#2122)" (#2130) This reverts commit 06a029d.
* React Native added support for hooks in 0.59 React Native 0.59 and above already support React Hooks, this line is no longer necessary, causes confusion for some people that it is not working right now. We can also mention React Native version if needed. * update with react native mention of hooks support * Update content/docs/hooks-faq.md suggested changes Co-Authored-By: Alexey Pyltsyn <lex61rus@gmail.com>
As a new React learner, this part was a bit confusing as I though that it was referencing `() => this.tick()` part of the code. My addition would help at least people like me.
Hi, I've met the same issue on [here](facebook/prop-types#200) at storybook and found the following [PR](facebook/prop-types#211) that adds the `elementType` feature. It could find the doc on npm, but not the official react site.
This reverts commit b84fb3d.
* Add React Conf to list of community conferences * Whoops, put right day in
Added ReactConf AU into bottom of list for 27 & 28 Feb 2020
* Added Render-Atlanta to list of conferences The first React focused conference around culture & inclusion will be held in the peach state, May 4 - 6, 2020. Full website is going live August 1, but signup page is currently active via our URL * Updated Position Accidentally put it @ the bottom under past conferences * Fixed order
* First pass at Profiler API docs
* Testing Docs This expands the testing docs for reactjs.org. It adds 3 main docs - - testing.md: An entry point to the testing docs - testing-recipes.md: Common patterns when writing tests for React Components. - testing-environments.md: Setting up your testing environment. With help from @alexkrolick, @kentcdodds, @gaearon
* Update testing-recipes.md Update timers section code to match described situation * Missed a spot
Type fix 'Diffrent' ➡️ 'Different'
2 small changes - consistent data-testid everywhere - one wrong assertion
"enountered" -> "encountered"
Nothing, fancy, just a list of links to the sections on the page. Also took the opportunity to add dividers between sections, and Title Case the titles.
"Get a hold" should be the phrasal verb "get ahold". See https://www.quickanddirtytips.com/education/grammar/a-hold-or-ahold?page=1
* Add a note about the codemod on the lifecycle warnings post https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html * missing fullstop. * Update 2018-03-27-update-on-async-rendering.md
added react conf iran 2019 to the list.
Add a new ReactJS hosted in Canarias 🇮🇨 (Spain)
Add resource/guide to learning React Hooks. An article inspired by the ReactJS.org documentation.
Closing #2193
* Update meetups.md Added Meetup link for the React Miami group * Update meetups.md Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
* Links to React Redux hooks api Since Hooks are already released for Redux, link the docs * Update hooks-faq.md Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
Spring is a popular library on top of motion with some useful developments
Deploy preview for react-docs-hu ready! Built with commit cc5dab9 |
gergely-nagy
approved these changes
Aug 12, 2019
@balazsorban44 be careful, do not squash merge this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at ddbd064
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.