Fix compatibility with beta versions of Sprockets #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubyGems made a change that causes this error when you're on a beta
version of Sprockets 4:
/home/vagrant/code/rbenv/versions/2.7.0/lib/ruby/gems/2.7.0/gems/react-rails-2.6.0/lib/react/jsx/sprockets_strategy.rb:40:in
`register_engine_with_mime_type': undefined method `register_engine' for Sprockets:Module (NoMethodError)
Here's the relevant commit:
ruby/rubygems@9836549#diff-94d386526b8b558035d4e4c7602d647c
And here's how the behavior of `Gemf::Version#<=>` has changed:
Before:
1:(main)> `gem --version`
=> "3.0.3\n"
2:(main)> Gem::Version.new("4.0.0.beta9") >= Gem::Version.new('4.x')
=> true
3:(main)> Gem::Version.new("4.0.0.beta9") >= Gem::Version.new('4.a')
=> true
After:
1:(main)> `gem --version`
=> "3.1.2\n"
2:(main)> Gem::Version.new("4.0.0.beta9") >= Gem::Version.new('4.x')
=> false
3:(main)> Gem::Version.new("4.0.0.beta9") >= Gem::Version.new('4.a')
=> true
Sprockets 4.0 is out now, but this is still a bug, and people shouldn't
be forced to upgrade because of it.
Member
|
Looks good, has tests, thank you for this gift :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RubyGems made a change that causes this error when you're on a beta version of Sprockets 4:
Here's the relevant commit:
ruby/rubygems@9836549#diff-94d386526b8b558035d4e4c7602d647c
And here's how the behavior of
Gemf::Version#<=>has changed:Before:
After:
Sprockets 4.0 is out now, but this is still a bug, and people shouldn't be forced to upgrade because of it.