update to react-source 0.12 final #105
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
We should probably also update examples and tests to not include the |
|
Right, didn't realize that would affect tests. Will do. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Tried to update the tests, but the build is failing because of some issue in calling React components directly - perhaps someone more familiar with the internals can help out? I assume these errors are related to a deprecation introduced in 0.12. |
|
Ok, I looked into the code a bit more and found out where the deprecated calls were coming from. The tests seem to be passing so let me know if there's anything else that needs to be done. |
There was a problem hiding this comment.
These gemfiles were autogenerated. Did you fix them manually or does an updated appraisal install do it?
There was a problem hiding this comment.
I didn't edit them manually, they were added by appraisal.
|
ping :) thank you for this project! |
|
Thanjs for the ping :) Let's do it. |
4 participants
No description provided.