Skip to content

Conversation

@zpao
Copy link
Member

@zpao zpao commented Jan 6, 2015

I'm really not sure about where this gem dependency should be specified. I remember being confused by this for dev dependencies in the past and just shoved everything in the gemspec. But I just listened to what Code Climate told me to do to set this up. Correct me if I'm wrong. cc @rmosolgo

@rmosolgo
Copy link
Member

rmosolgo commented Jan 6, 2015

Yeah, I don't know that bit too well either. I bet that example is for a Rails gemfile. Here's a working example where it's added with add_development_dependency:

https://github.com/jfelchner/ruby-progressbar/blob/master/ruby-progressbar.gemspec

Maybe that will magically fix the JRuby failure...

@rmosolgo
Copy link
Member

rmosolgo commented Jan 6, 2015

@rmosolgo
Copy link
Member

finished up in #274 🎉

@rmosolgo rmosolgo closed this May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants