Skip to content

Conversation

@djudd
Copy link
Contributor

@djudd djudd commented Jun 29, 2016

No description provided.

@rmosolgo
Copy link
Member

Nice, I guess this test covers .jsx.coffee, but it was previously failing on Sprockets 4? https://github.com/reactjs/react-rails/blob/master/test/react/jsx_test.rb#L46

I see Sprockets 4 passes now 🎉 where it used to fail ... do you want to move it from the "allow failures" group in .travis.yml? You got it passing, so I'll maintain it :P

@djudd
Copy link
Contributor Author

djudd commented Jun 29, 2016

Sure, I'll update travis.yml

@djudd
Copy link
Contributor Author

djudd commented Jun 29, 2016

Thanks for the quick response! I've been upgrading the https://www.academia.edu Rails app to Sprockets 4, and among the various things that needed patching, react-rails wins in response time & also quality of preexisting tests. ;)

@rmosolgo
Copy link
Member

Glad to hear it, thanks for the patch!

@rmosolgo rmosolgo merged commit deb8cb6 into reactjs:master Jun 29, 2016
@rmosolgo
Copy link
Member

Shipped in 1.8.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants