#639 Pass pre-render options to callback functions #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This patch looks great, but can you add a test to demonstrate the changed behavior? Sorry about the CI crash. I've updated |
Contributor
Author
|
Yepp, I`ll try something out |
Contributor
Author
|
Done that(https://travis-ci.org/reactjs/react-rails/builds/180025155), however the build on Travis is extremely slow. Why would you keep which always take 10 minutes and always fail? |
Member
|
I agree that the JRuby situation is not good! I think we moved them into "allow failures" for Rails 5, since no JRuby version supported Rails 5 at that time. It looks like they timeout now :( It would be nice to fix those, because I think we should support JRuby. Thanks for this improvement! It will make custom renderers more powerful! |
Member
|
🚢 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SprocketsRendererto preserve custom prerender options#639