Skip to content

Conversation

@buncis
Copy link
Contributor

@buncis buncis commented Dec 25, 2017

add javascript_pack_tag helper to readme.

Summary

mention javascript_pack_tag helper in README.md,
so people check it by themselves instead
creating a issue why their react component is not rendered

@BookOfGreg
Copy link
Member

It's always hard for me to understand what level of help to provide on our dependencies, thank you for helping myself and others see what is not obvious usage.
Could you either move it towards the Webpack section, or mark it as Webpack specific somehow, and then I'll merge it in.
Thank you for your help! Happy new year 😄

@buncis buncis force-pushed the master branch 2 times, most recently from f904ebe to b0415e3 Compare December 28, 2017 17:35
@buncis
Copy link
Contributor Author

buncis commented Dec 28, 2017

I have move it, Its better now
Thank you for your response, Happy new year 🎉

@BookOfGreg BookOfGreg merged commit 7590441 into reactjs:master Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants