Raise any JS error when prerendering #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Seems like a reasonable solution, better to raise than log and fail silently. Then the program can handle appropriately itself. I'm game to take this, I'll let it sit for a couple days and see if anybody else has comments. |
|
👍 |
zpao
added a commit
that referenced
this pull request
Sep 22, 2014
Raise any JS error when prerendering
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple attempt at solving #42. Even with better_errors it's not pretty:
But I'm not sure what else can be done. Have a look at how
ProgramErroris raised: https://github.com/sstephenson/execjs/search?utf8=%E2%9C%93&q=ProgramErrorIt looks like it only comes with a
message-- no stack trace. Any ideas on how to make this more useful?