Skip to content

✅ Update controller test to use params: when Rails 4+ #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2019
Merged

✅ Update controller test to use params: when Rails 4+ #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/react/rails/pages_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,26 @@ class PagesControllerTest < ActionController::TestCase

when_stateful_js_context_available do
test 'it sets up and tears down a react context' do
get :show, id: 1, prerender: true
get :show, query_params(id: 1, prerender: true)
assert_includes(response.body, 'Hello')

get :show, id: 1, prerender: true, greeting: 'Howdy'
get :show, query_params(id: 1, prerender: true, greeting: 'Howdy')
assert_includes(response.body, 'Howdy')

get :show, id: 1, prerender: true, greeting: '👋'
get :show, query_params(id: 1, prerender: true, greeting: '👋')
assert_includes(response.body, '👋')

get :show, id: 1, prerender: true
get :show, query_params(id: 1, prerender: true)
assert_includes(response.body, 'Hello')
end
end

WebpackerHelpers.when_webpacker_available do
test 'it mounts components from the dev server' do
WebpackerHelpers.with_dev_server do
get :show, id: 1, prerender: true
get :show, query_params(id: 1, prerender: true)
assert_match /Hello<!--.*--> from Webpacker/, response.body
get :show, id: 1, prerender: true, greeting: 'Howdy'
get :show, query_params(id: 1, prerender: true, greeting: 'Howdy')
assert_match /Howdy<!--.*--> from Webpacker/, response.body
end
end
Expand Down