Skip to content

Conversation

dnshi
Copy link

@dnshi dnshi commented Oct 25, 2015

React.render has been deprecated by React team. Use ReactDOM instead.

@taion
Copy link
Contributor

taion commented Oct 25, 2015

Per the rest of the code, we write this as

import { render } from 'react-dom'

render(/* ... */)

@dnshi
Copy link
Author

dnshi commented Oct 25, 2015

Okay, I update the code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I mis-spoke - better to drop this import entirely (since it wasn't there before anyway).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Sure!

@knowbody
Copy link
Contributor

@dnshi please squash your commits

@dnshi
Copy link
Author

dnshi commented Oct 25, 2015

@knowbody done!

knowbody added a commit that referenced this pull request Oct 25, 2015
@knowbody knowbody merged commit 9426e4f into remix-run:master Oct 25, 2015
@knowbody
Copy link
Contributor

thanks

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants