Fixes to PropTypes #3274
Closed
Fixes to PropTypes #3274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #3205 – I think I want to get rid of these prop type definitions entirely. Sorry, but thanks for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't really know why 'oneOfType' is left alone in 'Link' while others are defined in 'PropTypes.js'.
Found it cleaner to remove 'oneOfType' from Link and describe it in PropTypes as the others. Sure @taion or @timdorr has some input on why this is bad, but was worth as shot.
Also, I didn't find this to collide with #3218
Lastly; I'm sorry for so many PR's. I learn from your replies, which helps me to be a better programmer, writing future code. I'm very thankful for you answering PR's instead of just closing them, which would be quite tempting, as you get a lot of issues and PR's that's not right.