Added dummycheck #3328
Closed
Added dummycheck #3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 15, 2016 20:35
|
The former is much more expressive than the latter, and the premise of this being optimised is a false one. Why test for null and undefined explicitly when null and undefined are falsey? |
| function checkPropTypes(componentName, propTypes, props) { | ||
| componentName = componentName || 'UnknownComponent' | ||
|
|
||
| componentName = {} || '' |
There was a problem hiding this comment.
this will always be {}, obliterating the arg coming in. What's the goal with this PR?
|
Thanks for the notification, swapping it around as we speak 😄 |
added 2 commits
April 15, 2016 21:04
# Conflicts: # modules/RouteUtils.js
|
Closing this, fixing and let's resume this in the new PR, will go in detail there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped around so we don't need to use
componentName = componentName || somethingDoes basically the same thing ( I think?? ) but does a conditional instead so we can cross out invoking the object iteself to check if it's an object or string.
Feedback would be great. Passed all tests, but please, do check if returning the string is proper!
❤️