Update glossary to properly document greedy string matching #3360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybot1122
changed the title
ybot1122
changed the title
docs/Glossary.md
Outdated
| - `:paramName` – matches a URL segment up to the next `/`, `?`, or `#`. The matched string is called a [param](#params) | ||
| - `()` – Wraps a portion of the URL that is optional | ||
| - `*` – Matches all characters (non-greedy) up to the next character in the pattern, or to the end of the URL if there is none, and creates a `splat` [param](#params) | ||
| - `*` – Matches all characters (non-greedy) up to the next character in the pattern, or to the end of the URL if there is none, and creates a `splat` [param](/docs/Glossary.md#params) |
There was a problem hiding this comment.
Nit: Can you make those links not absolute? That means less work if we reorganize docs in the future, and when building them into a documentation website.
There was a problem hiding this comment.
I'll do that. And I'll keep it focused just on the pattern-matching links for this PR.
I'll be happy to raise a separate PR to relativize all other doc links.
ybot1122
force-pushed
the
documentation/glossary-greedy-matching
branch
from
c9a003d to
4097ee6
Compare
ybot1122
force-pushed
the
documentation/glossary-greedy-matching
branch
from
4097ee6 to
3ff4f60
Compare
|
Ah I should have paid more attention to the rest of the glossary links. I understand now. |
ybot1122
changed the title
ybot1122
changed the title
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2933 is the larger goal
#3359 raises my case for why this specific doc update should be prioritized