Skip to content

Conversation

@folt
Copy link
Contributor

@folt folt commented Apr 12, 2022

Improving the documentation will improve the developer experience and provide a solution for issues:
React 18 - typescript gives an error when reproducing official Upgrade Guide
[Bug]: createRoot type error - TS2345

@facebook-github-bot
Copy link
Collaborator

Hi @folt!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@gaearon
Copy link
Member

gaearon commented Apr 12, 2022

This is not a typescript example. We can add a separate typescript example below but we shouldn’t have invalid JS code as the only example.

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog post is written with JS in mind. This is not valid JS. Let’s think of another way.

@folt
Copy link
Contributor Author

folt commented Apr 12, 2022

The blog post is written with JS in mind. This is not valid JS. Let’s think of another way.

I propose to add a block with an example for typescript. What do you think?

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@folt folt requested a review from gaearon April 13, 2022 07:56
@gaearon
Copy link
Member

gaearon commented Apr 13, 2022

This still seems confusing to me. It breaks the flow of the page (all other examples have Before/After, but not this one), and it's inconsistent with the previous one (different ID).

@gaearon
Copy link
Member

gaearon commented Apr 13, 2022

I fixed it slightly differently. This doesn't fix all examples but should be enough for people to figure out how to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants